Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use stderr for detection mode #469

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jan 29, 2024

Rustc already (sometimes) uses stdout for sending some information, when using --deps, rustc sends extra things on stdout thus we cannot parse it anylonger.

Fixing #468

Rustc already (sometimes) uses `stdout` for sending some informations,
when using `--deps`, those informations are colliding.
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

An expected side effect of a successful `rustc` command invokation is
to build an `rlib` file. Thus, this commit re-run rustc after
translating with hax.
@franziskuskiefer franziskuskiefer added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit 1d57e17 Jan 29, 2024
10 checks passed
@franziskuskiefer franziskuskiefer deleted the fix-cli-deps branch January 29, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants